Commit a55eaf17 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: pcm: Warn if doubly preallocated 

Warn if snd_pcm_lib_preallocate_pages*() is applied to the stream that
has already the preallocated buffers and skip the allocation.  It's a
clearly a driver bug.

Link: https://lore.kernel.org/r/20191105191007.18150-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent abffd8d0

sound/core/pcm_memory.c

+2 −0
Original line number Diff line number Diff line
@@ -221,6 +221,8 @@ void snd_pcm_lib_preallocate_pages(struct snd_pcm_substream *substream, 
				  int type, struct device *data,

				  size_t size, size_t max)

{

	if (snd_BUG_ON(substream->dma_buffer.dev.type))

		return;

	substream->dma_buffer.dev.type = type;

	substream->dma_buffer.dev.dev = data;

	snd_pcm_lib_preallocate_pages1(substream, size, max);

CRA Git | Maintained and supported by SUSTech CRA and CCSE