Commit a55e601b authored Jan 07, 2020 by Arnd Bergmann Committed by Ilya Dryomov Jan 27, 2020

rbd: work around -Wuninitialized warning



gcc -O3 warns about a dummy variable that is passed
down into rbd_img_fill_nodata without being initialized:

drivers/block/rbd.c: In function 'rbd_img_fill_nodata':
drivers/block/rbd.c:2573:13: error: 'dummy' is used uninitialized in this function [-Werror=uninitialized]
  fctx->iter = *fctx->pos;

Since this is a dummy, I assume the warning is harmless, but
it's better to initialize it anyway and avoid the warning.

Fixes: mmtom ("init/Kconfig: enable -O3 for all arches")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 9ba1e224

drivers/block/rbd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2662,7 +2662,7 @@ static int rbd_img_fill_nodata(struct rbd_img_request *img_req,
		u64 off, u64 len)
		{
		struct ceph_file_extent ex = { off, len };
		union rbd_img_fill_iter dummy;
		union rbd_img_fill_iter dummy = {};
		struct rbd_img_fill_ctx fctx = {
		.pos_type = OBJ_REQUEST_NODATA,
		.pos = &dummy,

Admin message