Commit a558566b authored Dec 18, 2017 by Sudheer Mogilappagari Committed by Jeff Kirsher Jan 23, 2018

i40evf: remove flush_scheduled_work call in i40evf_remove



flush_schedule_work blocks until completion of all scheduled
work items in global work-queue. This can cause deadlock in some
cases. i40evf_remove() cleans up necessary work items with
cancel_delayed_work_sync and cancel_work_sync. This fix removes
flush_schedule_work call inside i40evf_remove().

Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent b356dac8

drivers/net/ethernet/intel/i40evf/i40evf_main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -3088,8 +3088,6 @@ static void i40evf_remove(struct pci_dev *pdev)
		if (adapter->watchdog_timer.function)
		del_timer_sync(&adapter->watchdog_timer);

		flush_scheduled_work();

		i40evf_free_rss(adapter);

		if (hw->aq.asq.count)

Admin message