Commit a555ad45 authored by Al Viro's avatar Al Viro
Browse files

whack-a-mole: no need to set_fs(USER_DS) in {start,flush}_thread() 



flush_old_exec() has already done that.  Back on 2011 a bunch of
instances like that had been kicked out, but that hadn't taken
care of then-out-of-tree architectures, obviously, and they served
as reinfection vector...

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 9e7543e9

arch/arc/kernel/process.c

+0 −2
Original line number Diff line number Diff line
@@ -155,8 +155,6 @@ int copy_thread(unsigned long clone_flags, 
 */

void start_thread(struct pt_regs * regs, unsigned long pc, unsigned long usp)

{

	set_fs(USER_DS); /* user space */



	regs->sp = usp;

	regs->ret = pc;

arch/c6x/kernel/process.c

+0 −1
Original line number Diff line number Diff line
@@ -101,7 +101,6 @@ void start_thread(struct pt_regs *regs, unsigned int pc, unsigned long usp) 
	 */

	usp -= 8;



	set_fs(USER_DS);

	regs->pc  = pc;

	regs->sp  = usp;

	regs->tsr |= 0x40; /* set user mode */

arch/hexagon/kernel/process.c

+0 −2
Original line number Diff line number Diff line
@@ -37,8 +37,6 @@ 
 */

void start_thread(struct pt_regs *regs, unsigned long pc, unsigned long sp)

{

	/* Set to run with user-mode data segmentation */

	set_fs(USER_DS);

	/* We want to zero all data-containing registers. Is this overkill? */

	memset(regs, 0, sizeof(*regs));

	/* We might want to also zero all Processor registers here */

arch/metag/include/asm/processor.h

+0 −1
Original line number Diff line number Diff line
@@ -111,7 +111,6 @@ struct thread_struct { 
 */

#define start_thread(regs, pc, usp) do {				   \

	unsigned int *argc = (unsigned int *) bprm->exec;		   \

	set_fs(USER_DS);						   \

	current->thread.int_depth = 1;					   \

	/* Force this process down to user land */			   \

	regs->ctx.SaveMask = TBICTX_PRIV_BIT;				   \

arch/nios2/kernel/process.c

+0 −1
Original line number Diff line number Diff line
@@ -94,7 +94,6 @@ void show_regs(struct pt_regs *regs) 


void flush_thread(void)

{

	set_fs(USER_DS);

}



int copy_thread(unsigned long clone_flags,

CRA Git | Maintained and supported by SUSTech CRA and CCSE