Commit a54cdeeb authored Oct 04, 2019 by Kai-Heng Feng Committed by David S. Miller Oct 04, 2019

r8152: Set macpassthru in reset_resume callback



r8152 may fail to establish network connection after resume from system
suspend.

If the USB port connects to r8152 lost its power during system suspend,
the MAC address was written before is lost. The reason is that The MAC
address doesn't get written again in its reset_resume callback.

So let's set MAC address again in reset_resume callback. Also remove
unnecessary lock as no other locking attempt will happen during
reset_resume.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6b517374

drivers/net/usb/r8152.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -4799,10 +4799,9 @@ static int rtl8152_reset_resume(struct usb_interface *intf)
		struct r8152 *tp = usb_get_intfdata(intf);

		clear_bit(SELECTIVE_SUSPEND, &tp->flags);
		mutex_lock(&tp->control);
		tp->rtl_ops.init(tp);
		queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0);
		mutex_unlock(&tp->control);
		set_ethernet_addr(tp);
		return rtl8152_resume(intf);
		}

Admin message