Commit a5437e0b authored Mar 12, 2020 by Dan Carpenter Committed by Alex Deucher Mar 13, 2020

drm/amd/display: clean up a condition in dmub_psr_copy_settings()



We can remove the NULL check for "res_ctx" and
"res_ctx->pipe_ctx[i].stream->link".  Also it's nicer to align the
conditions using spaces so I re-indented a bit.

Longer explanation: The "res_ctx" pointer points to an address in the
middle of a struct so it can't be NULL.  For
"res_ctx->pipe_ctx[i].stream->link" we know that it is equal to "link"
and "link" is non-NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 62458528

drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -134,9 +134,7 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub,
		int i = 0;

		for (i = 0; i < MAX_PIPES; i++) {
		if (res_ctx &&
		res_ctx->pipe_ctx[i].stream &&
		res_ctx->pipe_ctx[i].stream->link &&
		if (res_ctx->pipe_ctx[i].stream &&
		res_ctx->pipe_ctx[i].stream->link == link &&
		res_ctx->pipe_ctx[i].stream->link->connector_signal == SIGNAL_TYPE_EDP) {
		pipe_ctx = &res_ctx->pipe_ctx[i];

Admin message