[media] v4l2-async: remove unneeded .registered_async callback (a53d2f29) · Commits · 戴 / test

The v4l2_subdev_core_ops .registered_async callback was added to notify a subdev when its entity has been registered with the media device, to allow for example to modify the media graph (i.e: adding entities/links). But that's not needed since there is already a .registered callback in struct v4l2_subdev_internal_ops that's called after the entity has been registered with the media device in v4l2_device_register_subdev(). Suggested-by:

Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:

Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by:

Mauro Carvalho Chehab <mchehab@s-opensource.com>

drivers/media/v4l2-core/v4l2-async.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -119,13 +119,6 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
		return ret;
		}

		ret = v4l2_subdev_call(sd, core, registered_async);
		if (ret < 0 && ret != -ENOIOCTLCMD) {
		if (notifier->unbind)
		notifier->unbind(notifier, sd, asd);
		return ret;
		}

		if (list_empty(&notifier->waiting) && notifier->complete)
		return notifier->complete(notifier);

include/media/v4l2-subdev.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -184,8 +184,6 @@ struct v4l2_subdev_io_pin_config {
		* for it to be warned when the value of a control changes.
		*
		* @unsubscribe_event: remove event subscription from the control framework.
		*
		* @registered_async: the subdevice has been registered async.
		*/
		struct v4l2_subdev_core_ops {
		int (log_status)(struct v4l2_subdev sd);
		@@ -211,7 +209,6 @@ struct v4l2_subdev_core_ops {
		struct v4l2_event_subscription *sub);
		int (unsubscribe_event)(struct v4l2_subdev sd, struct v4l2_fh *fh,
		struct v4l2_event_subscription *sub);
		int (registered_async)(struct v4l2_subdev sd);
		};

		/**

Admin message