Commit a52ad514 authored by Jarod Wilson's avatar Jarod Wilson Committed by David S. Miller
Browse files

net: deprecate eth_change_mtu, remove usage 



With centralized MTU checking, there's nothing productive done by
eth_change_mtu that isn't already done in dev_set_mtu, so mark it as
deprecated and remove all usage of it in the kernel. All callers have been
audited for calls to alloc_etherdev* or ether_setup directly, which means
they all have a valid dev->min_mtu and dev->max_mtu. Now eth_change_mtu
prints out a netdev_warn about being deprecated, for the benefit of
out-of-tree drivers that might be utilizing it.

Of note, dvb_net.c actually had dev->mtu = 4096, while using
eth_change_mtu, meaning that if you ever tried changing it's mtu, you
couldn't set it above 1500 anymore. It's now getting dev->max_mtu also set
to 4096 to remedy that.

v2: fix up lantiq_etop, missed breakage due to drive not compiling on x86

CC: netdev@vger.kernel.org
Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 61e84623

arch/m68k/emu/nfeth.c

+0 −1
Original line number Diff line number Diff line
@@ -184,7 +184,6 @@ static const struct net_device_ops nfeth_netdev_ops = { 
	.ndo_start_xmit		= nfeth_xmit,

	.ndo_tx_timeout		= nfeth_tx_timeout,

	.ndo_validate_addr	= eth_validate_addr,

	.ndo_change_mtu		= eth_change_mtu,

	.ndo_set_mac_address	= eth_mac_addr,

};

drivers/isdn/hysdn/hysdn_net.c

+0 −1
Original line number Diff line number Diff line
@@ -232,7 +232,6 @@ static const struct net_device_ops hysdn_netdev_ops = { 
	.ndo_open		= net_open,

	.ndo_stop		= net_close,

	.ndo_start_xmit		= net_send_packet,

	.ndo_change_mtu		= eth_change_mtu,

	.ndo_set_mac_address	= eth_mac_addr,

	.ndo_validate_addr	= eth_validate_addr,

};

drivers/media/dvb-core/dvb_net.c

+1 −1
Original line number Diff line number Diff line
@@ -1198,7 +1198,6 @@ static const struct net_device_ops dvb_netdev_ops = { 
	.ndo_start_xmit		= dvb_net_tx,

	.ndo_set_rx_mode	= dvb_net_set_multicast_list,

	.ndo_set_mac_address    = dvb_net_set_mac,

	.ndo_change_mtu		= eth_change_mtu,

	.ndo_validate_addr	= eth_validate_addr,

};
@@ -1209,6 +1208,7 @@ static void dvb_net_setup(struct net_device *dev) 
	dev->header_ops		= &dvb_header_ops;

	dev->netdev_ops		= &dvb_netdev_ops;

	dev->mtu		= 4096;

	dev->max_mtu		= 4096;



	dev->flags |= IFF_NOARP;

}

drivers/net/appletalk/ipddp.c

+0 −1
Original line number Diff line number Diff line
@@ -59,7 +59,6 @@ static int ipddp_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd); 
static const struct net_device_ops ipddp_netdev_ops = {

	.ndo_start_xmit		= ipddp_xmit,

	.ndo_do_ioctl   	= ipddp_ioctl,

	.ndo_change_mtu		= eth_change_mtu,

	.ndo_set_mac_address 	= eth_mac_addr,

	.ndo_validate_addr	= eth_validate_addr,

};

drivers/net/cris/eth_v10.c

+0 −1
Original line number Diff line number Diff line
@@ -264,7 +264,6 @@ static const struct net_device_ops e100_netdev_ops = { 
	.ndo_do_ioctl		= e100_ioctl,

	.ndo_set_mac_address	= e100_set_mac_address,

	.ndo_validate_addr	= eth_validate_addr,

	.ndo_change_mtu		= eth_change_mtu,

	.ndo_set_config		= e100_set_config,

#ifdef CONFIG_NET_POLL_CONTROLLER

	.ndo_poll_controller	= e100_netpoll,

CRA Git | Maintained and supported by SUSTech CRA and CCSE