io_uring: fix ignoring xa_store errors (a528b04e) · Commits · 戴 / test

xa_store() may fail, check the result. Cc: stable@vger.kernel.org # 5.10 Fixes: ("io_uring: don't rely on weak ->files references") Signed-off-by:

fs/io_uring.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -8852,10 +8852,9 @@ static void io_uring_cancel_task_requests(struct io_ring_ctx *ctx,
		static int io_uring_add_task_file(struct io_ring_ctx ctx, struct file file)
		{
		struct io_uring_task *tctx = current->io_uring;

		if (unlikely(!tctx)) {
		int ret;

		if (unlikely(!tctx)) {
		ret = io_uring_alloc_task_context(current);
		if (unlikely(ret))
		return ret;
		@@ -8866,7 +8865,12 @@ static int io_uring_add_task_file(struct io_ring_ctx ctx, struct file file)

		if (!old) {
		get_file(file);
		xa_store(&tctx->xa, (unsigned long)file, file, GFP_KERNEL);
		ret = xa_err(xa_store(&tctx->xa, (unsigned long)file,
		file, GFP_KERNEL));
		if (ret) {
		fput(file);
		return ret;
		}
		}
		tctx->last = file;
		}