Commit a5124386 authored Jun 24, 2020 by Colin Ian King Committed by David S. Miller Jun 24, 2020

qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE



The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
enum dbg_status however there is a missing corresponding entry for
this in the array s_status_str. This causes an out-of-bounds read when
indexing into the last entry of s_status_str.  Fix this by adding in
the missing entry.

Addresses-Coverity: ("Out-of-bounds read").
Fixes: 2d22bc83 ("qed: FW 8.42.2.0 debug features")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 482f3bae

drivers/net/ethernet/qlogic/qed/qed_debug.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -5568,7 +5568,8 @@ static const char * const s_status_str[] = {

		/* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
		"The filter/trigger constraint dword offsets are not enabled for recording",

		/* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
		"No matching framing mode",

		/* DBG_STATUS_VFC_READ_ERROR */
		"Error reading from VFC",

Admin message