Commit a50ee7a7 authored Aug 15, 2007 by Matthew Wilcox Committed by James Bottomley Oct 12, 2007

[SCSI] ips: Close narrow race in release

We were releasing the IRQ before removing the host, so commands could
still be coming in which would never be seen by the interrupt handler.
Just remove the host before releasing the IRQ to close this race.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent f01abb36

drivers/scsi/ips.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -656,6 +656,8 @@ ips_release(struct Scsi_Host *sh)

		METHOD_TRACE("ips_release", 1);

		scsi_remove_host(sh);

		for (i = 0; i < IPS_MAX_ADAPTERS && ips_sh[i] != sh; i++) ;

		if (i == IPS_MAX_ADAPTERS) {
		@@ -707,7 +709,6 @@ ips_release(struct Scsi_Host *sh)
		/* free IRQ */
		free_irq(ha->irq, ha);

		scsi_remove_host(sh);
		scsi_host_put(sh);

		ips_released_controllers++;

Admin message