wcn36xx: simplify wcn36xx_smd_open() (a50c6c84) · Commits · 戴 / test

Drop the extra warning about failed allocations, both the core and the only caller of this function will warn loud enough in such cases. Signed-off-by:

Daniel Mack <daniel@zonque.org> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/ath/wcn36xx/smd.c

+3 −9

Original line number	Diff line number	Diff line
		@@ -2494,21 +2494,15 @@ static void wcn36xx_ind_smd_work(struct work_struct *work)
		}
		int wcn36xx_smd_open(struct wcn36xx *wcn)
		{
		int ret = 0;
		wcn->hal_ind_wq = create_freezable_workqueue("wcn36xx_smd_ind");
		if (!wcn->hal_ind_wq) {
		wcn36xx_err("failed to allocate wq\n");
		ret = -ENOMEM;
		goto out;
		}
		if (!wcn->hal_ind_wq)
		return -ENOMEM;

		INIT_WORK(&wcn->hal_ind_work, wcn36xx_ind_smd_work);
		INIT_LIST_HEAD(&wcn->hal_ind_queue);
		spin_lock_init(&wcn->hal_ind_lock);

		return 0;

		out:
		return ret;
		}

		void wcn36xx_smd_close(struct wcn36xx *wcn)

Admin message