Commit a507fbb9 authored Feb 22, 2019 by Oded Gabbay Committed by Greg Kroah-Hartman Feb 23, 2019

habanalabs: don't print result when rc indicates error



send_cpu_message() doesn't update the result parameter when an error
occurs in its code. Therefore, callers of send_cpu_message() shouldn't use
the result value when the return code indicates error.

This patch fixes a static checker warning in goya_test_cpu_queue(), where
that function did print the result even though the return code from
send_cpu_message() indicated error.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 91969173

drivers/misc/habanalabs/goya/goya.c

+10 −4

Original line number	Diff line number	Diff line
		@@ -3380,10 +3380,16 @@ int goya_test_cpu_queue(struct hl_device *hdev)
		rc = hdev->asic_funcs->send_cpu_message(hdev, (u32 *) &test_pkt,
		sizeof(test_pkt), HL_DEVICE_TIMEOUT_USEC, &result);

		if (!rc)
		dev_info(hdev->dev, "queue test on CPU queue succeeded\n");
		if (!rc) {
		if (result == ARMCP_PACKET_FENCE_VAL)
		dev_info(hdev->dev,
		"queue test on CPU queue succeeded\n");
		else
		dev_err(hdev->dev, "CPU queue test failed (0x%08lX)\n", result);
		dev_err(hdev->dev,
		"CPU queue test failed (0x%08lX)\n", result);
		} else {
		dev_err(hdev->dev, "CPU queue test failed, error %d\n", rc);
		}

		return rc;
		}

Admin message