Commit a4f2dacb authored Oct 30, 2014 by Or Gerlitz Committed by David S. Miller Oct 30, 2014

net/mlx4_en: Don't attempt to TX offload the outer UDP checksum for VXLAN



For VXLAN/NVGRE encapsulation, the current HW doesn't support offloading
both the outer UDP TX checksum and the inner TCP/UDP TX checksum.

The driver doesn't advertize SKB_GSO_UDP_TUNNEL_CSUM, however we are wrongly
telling the HW to offload the outer UDP checksum for encapsulated packets,
fix that.

Fixes: 837052d0 ('net/mlx4_en: Add netdev support for TCP/IP
		     offloads of vxlan tunneling')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9cc233fb

drivers/net/ethernet/mellanox/mlx4/en_tx.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -836,8 +836,11 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff skb, struct net_device dev)
		* whether LSO is used */
		tx_desc->ctrl.srcrb_flags = priv->ctrl_flags;
		if (likely(skb->ip_summed == CHECKSUM_PARTIAL)) {
		if (!skb->encapsulation)
		tx_desc->ctrl.srcrb_flags \|= cpu_to_be32(MLX4_WQE_CTRL_IP_CSUM \|
		MLX4_WQE_CTRL_TCP_UDP_CSUM);
		else
		tx_desc->ctrl.srcrb_flags \|= cpu_to_be32(MLX4_WQE_CTRL_IP_CSUM);
		ring->tx_csum++;
		}

Admin message