Commit a4ee4545 authored Sep 23, 2016 by Dave Gerlach Committed by Rafael J. Wysocki Sep 26, 2016

PM / OPP: Don't support OPP if it provides supported-hw but platform does not



The OPP framework allows each OPP to set a opp-supported-hw property
which provides values that are matched against supported_hw values
provided by the platform to limit support for certain OPPs on specific
hardware. Currently, if the platform does not set supported_hw values,
all OPPs are interpreted as supported, even if they have provided their
own opp-supported-hw values.

If an OPP has provided opp-supported-hw, it is indicating that there is
some specific hardware configuration it is supported by. These constraints
should be honored, and if no supported_hw has been provided by the
platform, there is no way to determine if that OPP is actually supported,
so it should be marked as not supported.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 4df27c91

drivers/base/power/opp/of.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -71,8 +71,18 @@ static bool _opp_is_supported(struct device dev, struct opp_table opp_table,
		u32 version;
		int ret;

		if (!opp_table->supported_hw)
		if (!opp_table->supported_hw) {
		/*
		* In the case that no supported_hw has been set by the
		* platform but there is an opp-supported-hw value set for
		* an OPP then the OPP should not be enabled as there is
		* no way to see if the hardware supports it.
		*/
		if (of_find_property(np, "opp-supported-hw", NULL))
		return false;
		else
		return true;
		}

		while (count--) {
		ret = of_property_read_u32_index(np, "opp-supported-hw", count,

Admin message