bpf: minor fix to selftest test_stacktrace_build_id() (a4e21ff8) · Commits · 戴 / test

1. remove useless parameter list to ./urandom_read 2. add missing "\n" to the end of an error message Fixes: ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID") Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by:

Song Liu <songliubraving@fb.com> Signed-off-by:

Daniel Borkmann <daniel@iogearbox.net>

tools/testing/selftests/bpf/test_progs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1108,7 +1108,7 @@ static void test_stacktrace_build_id(void)

		assert(system("dd if=/dev/urandom of=/dev/zero count=4 2> /dev/null")
		== 0);
		assert(system("./urandom_read if=/dev/urandom of=/dev/zero count=4 2> /dev/null") == 0);
		assert(system("./urandom_read") == 0);
		/* disable stack trace collection */
		key = 0;
		val = 1;
		@@ -1158,7 +1158,7 @@ static void test_stacktrace_build_id(void)
		} while (bpf_map_get_next_key(stackmap_fd, &previous_key, &key) == 0);

		CHECK(build_id_matches < 1, "build id match",
		"Didn't find expected build ID from the map");
		"Didn't find expected build ID from the map\n");

		disable_pmu:
		ioctl(pmu_fd, PERF_EVENT_IOC_DISABLE);

Admin message