gpio: tegra: Clean-up debugfs initialisation (a4de4304) · Commits · 戴 / test

The function tegra_gpio_debuginit() just calls debugfs_create_file() and given that there is already a stub function implemented for debugfs_create_file() when CONFIG_DEBUG_FS is not enabled, there is no need for the function tegra_gpio_debuginit() and so remove it. Finally, use a space and not a tab between the #ifdef and CONFIG_DEBUG_FS. Signed-off-by:

Jon Hunter <jonathanh@nvidia.com> Reviewed-by:

Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpio-tegra.c

+3 −15

Original line number	Diff line number	Diff line
		@@ -547,19 +547,6 @@ static int tegra_dbg_gpio_show(struct seq_file s, void unused)
		}

		DEFINE_SHOW_ATTRIBUTE(tegra_dbg_gpio);

		static void tegra_gpio_debuginit(struct tegra_gpio_info *tgi)
		{
		debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
		&tegra_dbg_gpio_fops);
		}

		#else

		static inline void tegra_gpio_debuginit(struct tegra_gpio_info *tgi)
		{
		}

		#endif

		static const struct dev_pm_ops tegra_gpio_pm_ops = {
		@@ -684,7 +671,8 @@ static int tegra_gpio_probe(struct platform_device *pdev)
		}
		}

		tegra_gpio_debuginit(tgi);
		debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
		&tegra_dbg_gpio_fops);

		return 0;
		}

Admin message