Commit a4dcad34 authored by Alex Elder's avatar Alex Elder Committed by David S. Miller
Browse files

net: ipa: remove endpoint delay mode feature 



A "delay mode" feature was put in place to work around a problem
that was observed during development of the upstream IPA driver.  It
used TX endpoint "delay mode" in order to prevent transmitting
packets toward the modem before it was ready.

A race condition that would explain the problem has long since been
fixed, and we have concluded that the "delay mode" feature is no
longer required.  So get rid of it.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4fa95248

drivers/net/ipa/ipa_data-sdm845.c

+0 −1
Original line number Diff line number Diff line
@@ -74,7 +74,6 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { 
				.tx = {

					.status_endpoint =

						IPA_ENDPOINT_MODEM_AP_RX,

					.delay	= true,

				},

			},

		},

drivers/net/ipa/ipa_data.h

+0 −6
Original line number Diff line number Diff line
@@ -80,18 +80,12 @@ struct gsi_channel_data { 
/**

 * struct ipa_endpoint_tx_data - configuration data for TX endpoints

 * @status_endpoint:	endpoint to which status elements are sent

 * @delay:		whether endpoint starts in delay mode

 *

 * Delay mode prevents a TX endpoint from transmitting anything, even if

 * commands have been presented to the hardware.  Once the endpoint exits

 * delay mode, queued transfer commands are sent.

 *

 * The @status_endpoint is only valid if the endpoint's @status_enable

 * flag is set.

 */

struct ipa_endpoint_tx_data {

	enum ipa_endpoint_name status_endpoint;

	bool delay;

};



/**

drivers/net/ipa/ipa_endpoint.c

+1 −3
Original line number Diff line number Diff line
@@ -1341,10 +1341,8 @@ int ipa_endpoint_stop(struct ipa_endpoint *endpoint) 
static void ipa_endpoint_program(struct ipa_endpoint *endpoint)

{

	if (endpoint->toward_ipa) {

		bool delay_mode = endpoint->data->tx.delay;



		if (endpoint->ipa->version != IPA_VERSION_4_2)

			ipa_endpoint_program_delay(endpoint, delay_mode);

			ipa_endpoint_program_delay(endpoint, false);

		ipa_endpoint_init_hdr_ext(endpoint);

		ipa_endpoint_init_aggr(endpoint);

		ipa_endpoint_init_deaggr(endpoint);

CRA Git | Maintained and supported by SUSTech CRA and CCSE