Commit a4cf30e1 authored Oct 30, 2015 by Vitaly Kuznetsov Committed by Martin K. Petersen Nov 11, 2015

scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice



The only user of scsi_prep_async_scan() is scsi_scan_host() and it
handles the situation correctly. Move 'called twice' reporting to debug
level as well.

The issue is observed on Hyper-V: on any device add/remove event storvsc
driver calls scsi_scan_host() and in case previous scan is still running
we get the message and stack dump on console.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Tested-by: Alex Ng <alexng@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent abc01f7d

drivers/scsi/scsi_scan.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1713,8 +1713,7 @@ static struct async_scan_data scsi_prep_async_scan(struct Scsi_Host shost)
		return NULL;

		if (shost->async_scan) {
		shost_printk(KERN_INFO, shost, "%s called twice\n", __func__);
		dump_stack();
		shost_printk(KERN_DEBUG, shost, "%s called twice\n", __func__);
		return NULL;
		}

Admin message