Commit a4c8723a authored Sep 06, 2019 by Tony Lindgren

bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()



Commit d098913a ("bus: ti-sysc: Fix clock handling for no-idle
quirks") fixed handling for no-idle quirk modules that are not enabled
by the bootloader.

But it also caused unpaired clockdomain calls that won't allow idling
the system. That's because clkdm_allow_idle_nolock() and
clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.

Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.

Fixes: d098913a ("bus: ti-sysc: Fix clock handling for no-idle quirks")
Cc: Keerthy <j-keerthy@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent a932b77b

drivers/bus/ti-sysc.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
		*/
		if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE \|
		SYSC_QUIRK_NO_IDLE_ON_INIT)) {
		sysc_clkdm_deny_idle(ddata);
		sysc_disable_main_clocks(ddata);
		sysc_disable_opt_clocks(ddata);
		sysc_clkdm_allow_idle(ddata);

Admin message