Commit a4bc746c authored Sep 20, 2016 by kbuild test robot Committed by Takashi Iwai Sep 20, 2016

ALSA: line6: fix ifnullfree.cocci warnings

sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

NULL check before some freeing functions is not needed.

Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Andrej Krutak <dev@andree.sk>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent a16039cb

sound/usb/line6/driver.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -480,7 +480,6 @@ static void line6_destruct(struct snd_card *card)
		/* Free buffer memory first. We cannot depend on the existence of private
		* data from the (podhd) module, it may be gone already during this call
		*/
		if (line6->buffer_message)
		kfree(line6->buffer_message);

		kfree(line6->buffer_listen);

Admin message