Commit a4ac01c3 authored by Peter Williams's avatar Peter Williams Committed by Ingo Molnar
Browse files

sched: fix bug in balance_tasks() 



There are two problems with balance_tasks() and how it used:

1. The variables best_prio and best_prio_seen (inherited from the old
move_tasks()) were only required to handle problems caused by the
active/expired arrays, the order in which they were processed and the
possibility that the task with the highest priority could be on either.
  These issues are no longer present and the extra overhead associated
with their use is unnecessary (and possibly wrong).

2. In the absence of CONFIG_FAIR_GROUP_SCHED being set, the same
this_best_prio variable needs to be used by all scheduling classes or
there is a risk of moving too much load.  E.g. if the highest priority
task on this at the beginning is a fairly low priority task and the rt
class migrates a task (during its turn) then that moved task becomes the
new highest priority task on this_rq but when the sched_fair class
initializes its copy of this_best_prio it will get the priority of the
original highest priority task as, due to the run queue locks being
held, the reschedule triggered by pull_task() will not have taken place.
  This could result in inappropriate overriding of skip_for_load and
excessive load being moved.

The attached patch addresses these problems by deleting all reference to
best_prio and best_prio_seen and making this_best_prio a reference
parameter to the various functions involved.

load_balance_fair() has also been modified so that this_best_prio is
only reset (in the loop) if CONFIG_FAIR_GROUP_SCHED is set.  This should
preserve the effect of helping spread groups' higher priority tasks
around the available CPUs while improving system performance when
CONFIG_FAIR_GROUP_SCHED isn't set.

Signed-off-by: default avatarPeter Williams <pwil3058@bigpond.net.au>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent aea25401

include/linux/sched.h

+1 −1
Original line number Diff line number Diff line
@@ -870,7 +870,7 @@ struct sched_class { 
			struct rq *busiest,

			unsigned long max_nr_move, unsigned long max_load_move,

			struct sched_domain *sd, enum cpu_idle_type idle,

			int *all_pinned);

			int *all_pinned, int *this_best_prio);



	void (*set_curr_task) (struct rq *rq);

	void (*task_tick) (struct rq *rq, struct task_struct *p);

kernel/sched.c

+11 −15
Original line number Diff line number Diff line
@@ -745,8 +745,7 @@ static int balance_tasks(struct rq *this_rq, int this_cpu, struct rq *busiest, 
		      unsigned long max_nr_move, unsigned long max_load_move,

		      struct sched_domain *sd, enum cpu_idle_type idle,

		      int *all_pinned, unsigned long *load_moved,

		      int this_best_prio, int best_prio, int best_prio_seen,

		      struct rq_iterator *iterator);

		      int *this_best_prio, struct rq_iterator *iterator);



#include "sched_stats.h"

#include "sched_rt.c"
@@ -2165,8 +2164,7 @@ static int balance_tasks(struct rq *this_rq, int this_cpu, struct rq *busiest, 
		      unsigned long max_nr_move, unsigned long max_load_move,

		      struct sched_domain *sd, enum cpu_idle_type idle,

		      int *all_pinned, unsigned long *load_moved,

		      int this_best_prio, int best_prio, int best_prio_seen,

		      struct rq_iterator *iterator)

		      int *this_best_prio, struct rq_iterator *iterator)

{

	int pulled = 0, pinned = 0, skip_for_load;

	struct task_struct *p;
@@ -2191,12 +2189,8 @@ next: 
	 */

	skip_for_load = (p->se.load.weight >> 1) > rem_load_move +

							 SCHED_LOAD_SCALE_FUZZ;

	if (skip_for_load && p->prio < this_best_prio)

		skip_for_load = !best_prio_seen && p->prio == best_prio;

	if (skip_for_load ||

	if ((skip_for_load && p->prio >= *this_best_prio) ||

	    !can_migrate_task(p, busiest, this_cpu, sd, idle, &pinned)) {



		best_prio_seen |= p->prio == best_prio;

		p = iterator->next(iterator->arg);

		goto next;

	}
@@ -2210,8 +2204,8 @@ next: 
	 * and the prescribed amount of weighted load.

	 */

	if (pulled < max_nr_move && rem_load_move > 0) {

		if (p->prio < this_best_prio)

			this_best_prio = p->prio;

		if (p->prio < *this_best_prio)

			*this_best_prio = p->prio;

		p = iterator->next(iterator->arg);

		goto next;

	}
@@ -2243,12 +2237,13 @@ static int move_tasks(struct rq *this_rq, int this_cpu, struct rq *busiest, 
{

	struct sched_class *class = sched_class_highest;

	unsigned long total_load_moved = 0;

	int this_best_prio = this_rq->curr->prio;



	do {

		total_load_moved +=

			class->load_balance(this_rq, this_cpu, busiest,

				ULONG_MAX, max_load_move - total_load_moved,

				sd, idle, all_pinned);

				sd, idle, all_pinned, &this_best_prio);

		class = class->next;

	} while (class && max_load_move > total_load_moved);
@@ -2266,10 +2261,12 @@ static int move_one_task(struct rq *this_rq, int this_cpu, struct rq *busiest, 
			 struct sched_domain *sd, enum cpu_idle_type idle)

{

	struct sched_class *class;

	int this_best_prio = MAX_PRIO;



	for (class = sched_class_highest; class; class = class->next)

		if (class->load_balance(this_rq, this_cpu, busiest,

					1, ULONG_MAX, sd, idle, NULL))

					1, ULONG_MAX, sd, idle, NULL,

					&this_best_prio))

			return 1;



	return 0;
@@ -3184,8 +3181,7 @@ static int balance_tasks(struct rq *this_rq, int this_cpu, struct rq *busiest, 
		      unsigned long max_nr_move, unsigned long max_load_move,

		      struct sched_domain *sd, enum cpu_idle_type idle,

		      int *all_pinned, unsigned long *load_moved,

		      int this_best_prio, int best_prio, int best_prio_seen,

		      struct rq_iterator *iterator)

		      int *this_best_prio, struct rq_iterator *iterator)

{

	*load_moved = 0;

kernel/sched_fair.c

+12 −20
Original line number Diff line number Diff line
@@ -929,6 +929,7 @@ static struct task_struct *load_balance_next_fair(void *arg) 
	return __load_balance_iterator(cfs_rq, cfs_rq->rb_load_balance_curr);

}



#ifdef CONFIG_FAIR_GROUP_SCHED

static int cfs_rq_best_prio(struct cfs_rq *cfs_rq)

{

	struct sched_entity *curr;
@@ -942,12 +943,13 @@ static int cfs_rq_best_prio(struct cfs_rq *cfs_rq) 


	return p->prio;

}

#endif



static unsigned long

load_balance_fair(struct rq *this_rq, int this_cpu, struct rq *busiest,

		  unsigned long max_nr_move, unsigned long max_load_move,

		  struct sched_domain *sd, enum cpu_idle_type idle,

			int *all_pinned)

		  int *all_pinned, int *this_best_prio)

{

	struct cfs_rq *busy_cfs_rq;

	unsigned long load_moved, total_nr_moved = 0, nr_moved;
@@ -958,10 +960,10 @@ load_balance_fair(struct rq *this_rq, int this_cpu, struct rq *busiest, 
	cfs_rq_iterator.next = load_balance_next_fair;



	for_each_leaf_cfs_rq(busiest, busy_cfs_rq) {

#ifdef CONFIG_FAIR_GROUP_SCHED

		struct cfs_rq *this_cfs_rq;

		long imbalance;

		long imbalances;

		unsigned long maxload;

		int this_best_prio, best_prio, best_prio_seen = 0;



		this_cfs_rq = cpu_cfs_rq(busy_cfs_rq, this_cpu);
@@ -975,27 +977,17 @@ load_balance_fair(struct rq *this_rq, int this_cpu, struct rq *busiest, 
		imbalance /= 2;

		maxload = min(rem_load_move, imbalance);



		this_best_prio = cfs_rq_best_prio(this_cfs_rq);

		best_prio = cfs_rq_best_prio(busy_cfs_rq);



		/*

		 * Enable handling of the case where there is more than one task

		 * with the best priority. If the current running task is one

		 * of those with prio==best_prio we know it won't be moved

		 * and therefore it's safe to override the skip (based on load)

		 * of any task we find with that prio.

		 */

		if (cfs_rq_curr(busy_cfs_rq) == &busiest->curr->se)

			best_prio_seen = 1;



		*this_best_prio = cfs_rq_best_prio(this_cfs_rq);

#else

#define maxload rem_load_move

#endif

		/* pass busy_cfs_rq argument into

		 * load_balance_[start|next]_fair iterators

		 */

		cfs_rq_iterator.arg = busy_cfs_rq;

		nr_moved = balance_tasks(this_rq, this_cpu, busiest,

				max_nr_move, maxload, sd, idle, all_pinned,

				&load_moved, this_best_prio, best_prio,

				best_prio_seen, &cfs_rq_iterator);

				&load_moved, this_best_prio, &cfs_rq_iterator);



		total_nr_moved += nr_moved;

		max_nr_move -= nr_moved;

kernel/sched_idletask.c

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ static unsigned long 
load_balance_idle(struct rq *this_rq, int this_cpu, struct rq *busiest,

			unsigned long max_nr_move, unsigned long max_load_move,

			struct sched_domain *sd, enum cpu_idle_type idle,

			int *all_pinned)

			int *all_pinned, int *this_best_prio)

{

	return 0;

}

kernel/sched_rt.c

+2 −17
Original line number Diff line number Diff line
@@ -176,26 +176,12 @@ static unsigned long 
load_balance_rt(struct rq *this_rq, int this_cpu, struct rq *busiest,

			unsigned long max_nr_move, unsigned long max_load_move,

			struct sched_domain *sd, enum cpu_idle_type idle,

			int *all_pinned)

			int *all_pinned, int *this_best_prio)

{

	int this_best_prio, best_prio, best_prio_seen = 0;

	int nr_moved;

	struct rq_iterator rt_rq_iterator;

	unsigned long load_moved;



	best_prio = sched_find_first_bit(busiest->rt.active.bitmap);

	this_best_prio = sched_find_first_bit(this_rq->rt.active.bitmap);



	/*

	 * Enable handling of the case where there is more than one task

	 * with the best priority.   If the current running task is one

	 * of those with prio==best_prio we know it won't be moved

	 * and therefore it's safe to override the skip (based on load)

	 * of any task we find with that prio.

	 */

	if (busiest->curr->prio == best_prio)

		best_prio_seen = 1;



	rt_rq_iterator.start = load_balance_start_rt;

	rt_rq_iterator.next = load_balance_next_rt;

	/* pass 'busiest' rq argument into
@@ -205,8 +191,7 @@ load_balance_rt(struct rq *this_rq, int this_cpu, struct rq *busiest, 


	nr_moved = balance_tasks(this_rq, this_cpu, busiest, max_nr_move,

			max_load_move, sd, idle, all_pinned, &load_moved,

			this_best_prio, best_prio, best_prio_seen,

			&rt_rq_iterator);

			this_best_prio, &rt_rq_iterator);



	return load_moved;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE