Commit a4985833 authored Jul 11, 2019 by Yang Shi Committed by Linus Torvalds Jul 12, 2019

mm/filemap.c: correct the comment about VM_FAULT_RETRY

Commit 6b4c9f44 ("filemap: drop the mmap_sem for all blocking
operations") changed when mmap_sem is dropped during filemap page fault
and when returning VM_FAULT_RETRY.

Correct the comment to reflect the change.

Link: http://lkml.kernel.org/r/1556234531-108228-1-git-send-email-yang.shi@linux.alibaba.com


Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f053cbd4

mm/filemap.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -2504,10 +2504,8 @@ static struct file do_async_mmap_readahead(struct vm_fault vmf,
		*
		* vma->vm_mm->mmap_sem must be held on entry.
		*
		* If our return value has VM_FAULT_RETRY set, it's because
		* lock_page_or_retry() returned 0.
		* The mmap_sem has usually been released in this case.
		* See __lock_page_or_retry() for the exception.
		* If our return value has VM_FAULT_RETRY set, it's because the mmap_sem
		* may be dropped before doing I/O or by lock_page_maybe_drop_mmap().
		*
		* If our return value does not have VM_FAULT_RETRY set, the mmap_sem
		* has not been released.

Admin message