Commit a48a52b7 authored Jan 15, 2018 by Johannes Berg

cfg80211: fully initialize old channel for event



Paul reported that he got a report about undefined behaviour
that seems to me to originate in using uninitialized memory
when the channel structure here is used in the event code in
nl80211 later.

He never reported whether this fixed it, and I wasn't able
to trigger this so far, but we should do the right thing and
fully initialize the on-stack structure anyway.

Reported-by: Paul Menzel <pmenzel+linux-wireless@molgen.mpg.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 8155aedf

net/wireless/reg.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1769,8 +1769,7 @@ static void handle_reg_beacon(struct wiphy *wiphy, unsigned int chan_idx,
		if (wiphy->regulatory_flags & REGULATORY_DISABLE_BEACON_HINTS)
		return;

		chan_before.center_freq = chan->center_freq;
		chan_before.flags = chan->flags;
		chan_before = *chan;

		if (chan->flags & IEEE80211_CHAN_NO_IR) {
		chan->flags &= ~IEEE80211_CHAN_NO_IR;

Admin message