Commit a47070aa authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: smbus: remove outdated references to irq level triggers 



IRQ levels are now handled within the IRQ core. Remove the forgotten
references from the documentation.

Fixes: 9b9f2b8b ("i2c: i2c-smbus: Use threaded irq for smbalert")
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarLuca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent ed680522

drivers/i2c/i2c-core-smbus.c

+0 −5
Original line number Diff line number Diff line
@@ -676,11 +676,6 @@ EXPORT_SYMBOL(i2c_smbus_read_i2c_block_data_or_emulated); 
 * Handling can be done either through our IRQ handler, or by the

 * adapter (from its handler, periodic polling, or whatever).

 *

 * NOTE that if we manage the IRQ, we *MUST* know if it's level or

 * edge triggered in order to hand it to the workqueue correctly.

 * If triggering the alert seems to wedge the system, you probably

 * should have said it's level triggered.

 *

 * This returns the ara client, which should be saved for later use with

 * i2c_handle_smbus_alert() and ultimately i2c_unregister_device(); or an

 * ERRPTR to indicate an error.

include/linux/i2c-smbus.h

+0 −5
Original line number Diff line number Diff line
@@ -15,17 +15,12 @@ 


/**

 * i2c_smbus_alert_setup - platform data for the smbus_alert i2c client

 * @alert_edge_triggered: whether the alert interrupt is edge (1) or level (0)

 *		triggered

 * @irq: IRQ number, if the smbus_alert driver should take care of interrupt

 *		handling

 *

 * If irq is not specified, the smbus_alert driver doesn't take care of

 * interrupt handling. In that case it is up to the I2C bus driver to either

 * handle the interrupts or to poll for alerts.

 *

 * If irq is specified then it it crucial that alert_edge_triggered is

 * properly set.

 */

struct i2c_smbus_alert_setup {

	int			irq;

CRA Git | Maintained and supported by SUSTech CRA and CCSE