Commit a46fa684 authored May 04, 2009 by Tao Ma Committed by Joel Becker May 05, 2009

ocfs2: Don't printk the error when listing too many xattrs.



Currently the kernel defines XATTR_LIST_MAX as 65536
in include/linux/limits.h.  This is the largest buffer that is used for
listing xattrs.

But with ocfs2 xattr tree, we actually have no limit for the number.  If
filesystem has more names than can fit in the buffer, the kernel
logs will be pollluted with something like this when listing:

(27738,0):ocfs2_iterate_xattr_buckets:3158 ERROR: status = -34
(27738,0):ocfs2_xattr_tree_list_index_block:3264 ERROR: status = -34

So don't print "ERROR" message as this is not an ocfs2 error.

Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>

parent b4348f32

fs/ocfs2/xattr.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -3154,7 +3154,7 @@ static int ocfs2_iterate_xattr_buckets(struct inode *inode,
		le32_to_cpu(bucket_xh(bucket)->xh_entries[0].xe_name_hash));
		if (func) {
		ret = func(inode, bucket, para);
		if (ret)
		if (ret && ret != -ERANGE)
		mlog_errno(ret);
		/* Fall through to bucket_relse() */
		}
		@@ -3261,6 +3261,7 @@ static int ocfs2_xattr_tree_list_index_block(struct inode *inode,
		ocfs2_list_xattr_bucket,
		&xl);
		if (ret) {
		if (ret != -ERANGE)
		mlog_errno(ret);
		goto out;
		}

Admin message