Commit a465321a authored Nov 03, 2017 by Shuah Khan Committed by Mauro Carvalho Chehab Dec 18, 2017

media: s5p-mfc: Remove firmware buf null check in s5p_mfc_load_firmware()



s5p_mfc_load_firmware() will not get called if fw_buf.virt allocation
fails. The allocation happens very early on in the probe routine and
probe fails if allocation fails.

There is no need to check if it is null in s5p_mfc_load_firmware().
Remove the check.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent bc7eb5d7

drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -75,11 +75,6 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev)
		release_firmware(fw_blob);
		return -ENOMEM;
		}
		if (!dev->fw_buf.virt) {
		mfc_err("MFC firmware is not allocated\n");
		release_firmware(fw_blob);
		return -EINVAL;
		}
		memcpy(dev->fw_buf.virt, fw_blob->data, fw_blob->size);
		wmb();
		release_firmware(fw_blob);

Admin message