Commit a45aca51 authored Jul 07, 2020 by Abhishek Pandit-Subedi Committed by Rafael J. Wysocki Jul 14, 2020

PM: sleep: core: Emit changed uevent on wakeup_sysfs_add/remove



Udev rules that depend on the power/wakeup attribute don't get triggered
correctly if device_set_wakeup_capable is called after the device is
created. This can happen for several reasons (driver sets wakeup after
device is created, wakeup is changed on parent device, etc) and it seems
reasonable to emit a changed event when adding or removing attributes on
the device.

Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 11ba4688

drivers/base/power/sysfs.c

+8 −1

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0
		/* sysfs entries for device PM */
		#include <linux/device.h>
		#include <linux/kobject.h>
		#include <linux/string.h>
		#include <linux/export.h>
		#include <linux/pm_qos.h>
		@@ -739,12 +740,18 @@ int dpm_sysfs_change_owner(struct device *dev, kuid_t kuid, kgid_t kgid)

		int wakeup_sysfs_add(struct device *dev)
		{
		return sysfs_merge_group(&dev->kobj, &pm_wakeup_attr_group);
		int ret = sysfs_merge_group(&dev->kobj, &pm_wakeup_attr_group);

		if (!ret)
		kobject_uevent(&dev->kobj, KOBJ_CHANGE);

		return ret;
		}

		void wakeup_sysfs_remove(struct device *dev)
		{
		sysfs_unmerge_group(&dev->kobj, &pm_wakeup_attr_group);
		kobject_uevent(&dev->kobj, KOBJ_CHANGE);
		}

		int pm_qos_sysfs_add_resume_latency(struct device *dev)

Admin message