Commit a4564ead authored Feb 10, 2012 by Jan Kara Committed by Joel Becker Jul 03, 2012

ocfs2: Fix bogus error message from ocfs2_global_read_info



'status' variable in ocfs2_global_read_info() is always != 0 when leaving the
function because it happens to contain number of read bytes. Thus we always log
error message although everything is OK. Since all error cases properly call
mlog_errno() before jumping to out_err, there's no reason to call mlog_errno()
on exit at all. This is a fallout of c1e8d35e (conversion of mlog_exit()
calls).

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Joel Becker <jlbec@evilplan.org>

parent 65622e64

fs/ocfs2/quota_global.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -399,8 +399,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type)
		msecs_to_jiffies(oinfo->dqi_syncms));

		out_err:
		if (status)
		mlog_errno(status);
		return status;
		out_unlock:
		ocfs2_unlock_global_qf(oinfo, 0);

Admin message