Commit a44f53fa authored by Javier González's avatar Javier González Committed by Jens Axboe
Browse files

lightnvm: pblk: fix erase counters on error fail 



When block erases fail, these blocks are marked bad. The number of valid
blocks in the line was not updated, which could cause an infinite loop
on the erase path.

Fix this atomic counter and, in order to avoid taking an irq lock on the
interrupt context, make the erase counters atomic too.

Also, in the case that a significant number of blocks become bad in a
line, the result is the double shared metadata buffer (emeta) to stop
the pipeline until all metadata is flushed to the media. Increase the
number of metadata lines from 2 to 4 to avoid this case.

Fixes: a4bd217b "lightnvm: physical block device (pblk) target"

Signed-off-by: default avatarJavier González <javier@cnexlabs.com>
Reviewed-by: default avatarMatias Bjørling <matias@cnexlabs.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent be388d9f

drivers/lightnvm/pblk-core.c

+19 −9
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ static void pblk_mark_bb(struct pblk *pblk, struct pblk_line *line, 
	pr_debug("pblk: erase failed: line:%d, pos:%d\n", line->id, pos);

	atomic_long_inc(&pblk->erase_failed);



	atomic_dec(&line->blk_in_line);

	if (test_and_set_bit(pos, line->blk_bitmap))

		pr_err("pblk: attempted to erase bb: line:%d, pos:%d\n",

							line->id, pos);
@@ -832,21 +833,28 @@ int pblk_line_erase(struct pblk *pblk, struct pblk_line *line) 
	struct ppa_addr ppa;

	int bit = -1;



	/* Erase one block at the time and only erase good blocks */

	while ((bit = find_next_zero_bit(line->erase_bitmap, lm->blk_per_line,

						bit + 1)) < lm->blk_per_line) {

	/* Erase only good blocks, one at a time */

	do {

		spin_lock(&line->lock);

		bit = find_next_zero_bit(line->erase_bitmap, lm->blk_per_line,

								bit + 1);

		if (bit >= lm->blk_per_line) {

			spin_unlock(&line->lock);

			break;

		}



		ppa = pblk->luns[bit].bppa; /* set ch and lun */

		ppa.g.blk = line->id;



		/* If the erase fails, the block is bad and should be marked */

		line->left_eblks--;

		atomic_dec(&line->left_eblks);

		WARN_ON(test_and_set_bit(bit, line->erase_bitmap));

		spin_unlock(&line->lock);



		if (pblk_blk_erase_sync(pblk, ppa)) {

			pr_err("pblk: failed to erase line %d\n", line->id);

			return -ENOMEM;

		}

	}

	} while (1);



	return 0;

}
@@ -1007,6 +1015,7 @@ retry_smeta: 
static int pblk_line_prepare(struct pblk *pblk, struct pblk_line *line)

{

	struct pblk_line_meta *lm = &pblk->lm;

	int blk_in_line = atomic_read(&line->blk_in_line);



	line->map_bitmap = mempool_alloc(pblk->line_meta_pool, GFP_ATOMIC);

	if (!line->map_bitmap)
@@ -1030,12 +1039,13 @@ static int pblk_line_prepare(struct pblk *pblk, struct pblk_line *line) 
		return -EINTR;

	}

	line->state = PBLK_LINESTATE_OPEN;



	atomic_set(&line->left_eblks, blk_in_line);

	atomic_set(&line->left_seblks, blk_in_line);

	spin_unlock(&line->lock);



	/* Bad blocks do not need to be erased */

	bitmap_copy(line->erase_bitmap, line->blk_bitmap, lm->blk_per_line);

	line->left_eblks = line->blk_in_line;

	atomic_set(&line->left_seblks, line->left_eblks);



	kref_init(&line->ref);
@@ -1231,7 +1241,7 @@ retry_line: 
	left_seblks = atomic_read(&new->left_seblks);

	if (left_seblks) {

		/* If line is not fully erased, erase it */

		if (new->left_eblks) {

		if (atomic_read(&new->left_eblks)) {

			if (pblk_line_erase(pblk, new))

				return NULL;

		} else {

drivers/lightnvm/pblk-gc.c

+1 −1
Original line number Diff line number Diff line
@@ -332,7 +332,7 @@ next_gc_group: 
		}



		line = list_first_entry(group_list, struct pblk_line, list);

		nr_blocks_free += line->blk_in_line;

		nr_blocks_free += atomic_read(&line->blk_in_line);



		spin_lock(&line->lock);

		WARN_ON(line->state != PBLK_LINESTATE_CLOSED);

drivers/lightnvm/pblk-init.c

+6 −3
Original line number Diff line number Diff line
@@ -678,6 +678,8 @@ add_emeta_page: 


	nr_free_blks = 0;

	for (i = 0; i < l_mg->nr_lines; i++) {

		int blk_in_line;



		line = &pblk->lines[i];



		line->pblk = pblk;
@@ -693,14 +695,15 @@ add_emeta_page: 
			goto fail_free_lines;

		}



		line->blk_in_line = lm->blk_per_line - nr_bad_blks;

		if (line->blk_in_line < lm->min_blk_line) {

		blk_in_line = lm->blk_per_line - nr_bad_blks;

		if (blk_in_line < lm->min_blk_line) {

			line->state = PBLK_LINESTATE_BAD;

			list_add_tail(&line->list, &l_mg->bad_list);

			continue;

		}



		nr_free_blks += line->blk_in_line;

		nr_free_blks += blk_in_line;

		atomic_set(&line->blk_in_line, blk_in_line);



		l_mg->nr_free_lines++;

		list_add_tail(&line->list, &l_mg->free_list);

drivers/lightnvm/pblk-map.c

+2 −2
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ void pblk_map_erase_rq(struct pblk *pblk, struct nvm_rq *rqd, 
				continue;



			set_bit(erase_lun, e_line->erase_bitmap);

			e_line->left_eblks--;

			atomic_dec(&e_line->left_eblks);

			*erase_ppa = rqd->ppa_list[i];

			erase_ppa->g.blk = e_line->id;
@@ -129,7 +129,7 @@ void pblk_map_erase_rq(struct pblk *pblk, struct nvm_rq *rqd, 
			return;



		set_bit(i, e_line->erase_bitmap);

		e_line->left_eblks--;

		atomic_dec(&e_line->left_eblks);

		*erase_ppa = pblk->luns[i].bppa; /* set ch and lun */

		erase_ppa->g.blk = e_line->id;

	}

drivers/lightnvm/pblk-rl.c

+4 −2
Original line number Diff line number Diff line
@@ -107,9 +107,10 @@ void pblk_rl_set_gc_rsc(struct pblk_rl *rl, int rsv) 
void pblk_rl_free_lines_inc(struct pblk_rl *rl, struct pblk_line *line)

{

	struct pblk *pblk = container_of(rl, struct pblk, rl);

	int blk_in_line = atomic_read(&line->blk_in_line);

	int ret;



	atomic_add(line->blk_in_line, &rl->free_blocks);

	atomic_add(blk_in_line, &rl->free_blocks);

	/* Rates will not change that often - no need to lock update */

	ret = pblk_rl_update_rates(rl, rl->rb_budget);
@@ -122,9 +123,10 @@ void pblk_rl_free_lines_inc(struct pblk_rl *rl, struct pblk_line *line) 
void pblk_rl_free_lines_dec(struct pblk_rl *rl, struct pblk_line *line)

{

	struct pblk *pblk = container_of(rl, struct pblk, rl);

	int blk_in_line = atomic_read(&line->blk_in_line);

	int ret;



	atomic_sub(line->blk_in_line, &rl->free_blocks);

	atomic_sub(blk_in_line, &rl->free_blocks);



	/* Rates will not change that often - no need to lock update */

	ret = pblk_rl_update_rates(rl, rl->rb_budget);

CRA Git | Maintained and supported by SUSTech CRA and CCSE