Commit a4264b3f authored Dec 12, 2010 by Jesper Juhl Committed by Jan Kara Jan 06, 2011

UDF: Close small mem leak in udf_find_entry()



Hi,

There's a small memory leak in fs/udf/namei.c::udf_find_entry().

We dynamically allocate memory for 'fname' with kmalloc() and in most
situations we free it before we leave the function, but there is one
situation where we do not (but should). This patch closes the leak by
jumping to the 'out_ok' label which does the correct cleanup rather than
doing half the cleanup and returning directly.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jan Kara <jack@suse.cz>

parent 4651c590

fs/udf/namei.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -227,10 +227,8 @@ static struct fileIdentDesc udf_find_entry(struct inode dir,
		}

		if ((cfi->fileCharacteristics & FID_FILE_CHAR_PARENT) &&
		isdotdot) {
		brelse(epos.bh);
		return fi;
		}
		isdotdot)
		goto out_ok;

		if (!lfi)
		continue;

Admin message