Commit a412ec27 authored Jan 28, 2015 by Dan Carpenter Committed by Mark Brown Jan 28, 2015

regulator: qcom-rpm: signedness bug in probe()



"force_mode" is a u32 so it is never "< 0", but because of type
promotion then comparing "== -1" will do what we want.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 97bf6af1

drivers/regulator/qcom_rpm-regulator.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -768,7 +768,7 @@ static int rpm_reg_probe(struct platform_device *pdev)
		break;
		}

		if (force_mode < 0) {
		if (force_mode == -1) {
		dev_err(&pdev->dev, "invalid force mode\n");
		return -EINVAL;
		}

Admin message