Commit a3f6dfb7 authored Jun 17, 2009 by Oleg Nesterov Committed by Linus Torvalds Jun 18, 2009

do_wait: kill the old BUG_ON, use while_each_thread()



do_wait() does BUG_ON(tsk->signal != current->signal), this looks like a
raher obsolete check.  At least, I don't think do_wait() is the best place
to verify that all threads have the same ->signal.  Remove it.

Also, change the code to use while_each_thread().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 64a16caf

kernel/exit.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1595,9 +1595,7 @@ repeat:

		if (wo->wo_flags & __WNOTHREAD)
		break;
		tsk = next_thread(tsk);
		BUG_ON(tsk->signal != current->signal);
		} while (tsk != current);
		} while_each_thread(current, tsk);
		read_unlock(&tasklist_lock);

		notask:

Admin message