ASoC: Intel: hda_dsp_common: use static function in conditional block (a3f18f82) · Commits · 戴 / test

cppcheck reports the following warning: sound/soc/intel/boards/hda_dsp_common.c:17:0: style: The function 'hda_dsp_hdmi_pcm_handle' is never used. [unusedFunction] Fix by moving to static inside compilation block. Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by:

Jaska Uimonen <jaska.uimonen@intel.com> Signed-off-by:

Kai Vehmanen <kai.vehmanen@linux.intel.com> Link: https://lore.kernel.org/r/20200923072939.3100468-1-kai.vehmanen@linux.intel.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/intel/boards/hda_dsp_common.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -10,11 +10,13 @@

		#include "hda_dsp_common.h"

		#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC)

		/*
		* Search card topology and return PCM device number
		* matching Nth HDMI device (zero-based index).
		*/
		struct snd_pcm hda_dsp_hdmi_pcm_handle(struct snd_soc_card card,
		static struct snd_pcm hda_dsp_hdmi_pcm_handle(struct snd_soc_card card,
		int hdmi_idx)
		{
		struct snd_soc_pcm_runtime *rtd;
		@@ -34,7 +36,6 @@ struct snd_pcm hda_dsp_hdmi_pcm_handle(struct snd_soc_card card,
		return NULL;
		}

		#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC)
		/*
		* Search card topology and register HDMI PCM related controls
		* to codec driver.

sound/soc/intel/boards/hda_dsp_common.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -15,9 +15,6 @@
		#include <sound/hda_i915.h>
		#include "../../codecs/hdac_hda.h"

		struct snd_pcm hda_dsp_hdmi_pcm_handle(struct snd_soc_card card,
		int hdmi_idx);

		#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC)
		int hda_dsp_hdmi_build_controls(struct snd_soc_card *card,
		struct snd_soc_component *comp);

Admin message