Commit a3bc18a4 authored Sep 26, 2019 by David Howells Committed by Al Viro Sep 26, 2019

jffs2: Fix mounting under new mount API



The mounting of jffs2 is broken due to the changes from the new mount API
because it specifies a "source" operation, but then doesn't actually
process it.  But because it specified it, it doesn't return -ENOPARAM and
the caller doesn't process it either and the source gets lost.

Fix this by simply removing the source parameter from jffs2 and letting the
VFS deal with it in the default manner.

To test it, enable CONFIG_MTD_MTDRAM and allow the default size and erase
block size parameters, then try and mount the /dev/mtdblock<N> file that
that creates as jffs2.  No need to initialise it.

Fixes: ec10a24f ("vfs: Convert jffs2 to use the new mount API")
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: David Woodhouse <dwmw2@infradead.org>
cc: Richard Weinberger <richard@nod.at>
cc: linux-mtd@lists.infradead.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 1f52aa08

fs/jffs2/super.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -163,13 +163,11 @@ static const struct export_operations jffs2_export_ops = {
		* Opt_rp_size: size of reserved pool in KiB
		*/
		enum {
		Opt_source,
		Opt_override_compr,
		Opt_rp_size,
		};

		static const struct fs_parameter_spec jffs2_param_specs[] = {
		fsparam_string ("source", Opt_source),
		fsparam_enum ("compr", Opt_override_compr),
		fsparam_u32 ("rp_size", Opt_rp_size),
		{}

Admin message