Commit a39cddc9 authored Dec 05, 2019 by Ulf Hansson Committed by Vinod Koul Dec 10, 2019

dmaengine: pl330: Drop boilerplate code for suspend/resume

Let's drop the boilerplate code in the system suspend/resume callbacks and
convert to use pm_runtime_force_suspend|resume(). This change also has a
nice side effect, as pm_runtime_force_resume() may decide to leave the
device in low power state, when that is feasible, thus avoiding to waste
both time and energy during system resume.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20191205143746.24873-2-ulf.hansson@linaro.org

Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent c64738d6

drivers/dma/pl330.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -2961,12 +2961,7 @@ static int __maybe_unused pl330_suspend(struct device *dev)
		{
		struct amba_device *pcdev = to_amba_device(dev);

		pm_runtime_disable(dev);

		if (!pm_runtime_status_suspended(dev)) {
		/* amba did not disable the clock */
		amba_pclk_disable(pcdev);
		}
		pm_runtime_force_suspend(dev);
		amba_pclk_unprepare(pcdev);

		return 0;
		@@ -2981,10 +2976,7 @@ static int __maybe_unused pl330_resume(struct device *dev)
		if (ret)
		return ret;

		if (!pm_runtime_status_suspended(dev))
		ret = amba_pclk_enable(pcdev);

		pm_runtime_enable(dev);
		pm_runtime_force_resume(dev);

		return ret;
		}