Commit a3958323 authored Feb 28, 2020 by Luca Ceresoli Committed by Rob Herring Mar 02, 2020

of: overlay: log the error cause on resolver failure



When a DT overlay has a node label that is not present in the live
devicetree symbols table, this error is printed:

  OF: resolver: overlay phandle fixup failed: -22
  create_overlay: Failed to create overlay (err=-22)

which does not help much in finding the node label that caused the problem
and fix the overlay source.

Add an error message with the name of the node label that caused the
error. The new output is:

  OF: resolver: node label 'gpio9' not found in live devicetree symbols table
  OF: resolver: overlay phandle fixup failed: -22
  create_overlay: Failed to create overlay (err=-22)

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>

parent 485bb19d

drivers/of/resolver.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -321,8 +321,11 @@ int of_resolve_phandles(struct device_node *overlay)

		err = of_property_read_string(tree_symbols,
		prop->name, &refpath);
		if (err)
		if (err) {
		pr_err("node label '%s' not found in live devicetree symbols table\n",
		prop->name);
		goto out;
		}

		refnode = of_find_node_by_path(refpath);
		if (!refnode) {

Admin message