Commit a3930ed0 authored Aug 27, 2016 by Chen-Yu Tsai Committed by Mark Brown Sep 01, 2016

ASoC: dapm: Fix kcontrol creation for output driver widget



Commit d88429a6 ("ASoC: dapm: Add output driver widget") added
the snd_soc_dapm_out_drv ID for the output driver widget, which is
the same as the PGA widget, with a later power sequence number.

Commit 19a2557b ("ASoC: dapm: Add kcontrol support for PGAs")
then added kcontrol support for PGA widgets, but failed to account
for output driver widgets. Attempts to use kcontrols with output
driver widgets result in silent failures, with the developer having
little idea about what went on.

Add snd_soc_dapm_out_drv to the switch/case block under snd_soc_dapm_pga
in dapm_create_or_share_kcontrol, since they are essentially the same.

Fixes: 19a2557b (ASoC: dapm: Add kcontrol support for PGAs)
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 071133a2

sound/soc/soc-dapm.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -823,6 +823,7 @@ static int dapm_create_or_share_kcontrol(struct snd_soc_dapm_widget *w,
		case snd_soc_dapm_switch:
		case snd_soc_dapm_mixer:
		case snd_soc_dapm_pga:
		case snd_soc_dapm_out_drv:
		wname_in_long_name = true;
		kcname_in_long_name = true;
		break;

Admin message