wil6210: fix invalid sta statistics update (a380eb57) · Commits · 戴 / test

Upon status ring handling, in case there are both unicast and multicast (cid == max) status messages to handle, wrong sta statistics might get updated. Fix this by setting stats to NULL upon invalid cid (e.g. == max_assoc_sta). Signed-off-by:

Dedy Lansky <dlansky@codeaurora.org> Signed-off-by:

Maya Erez <merez@codeaurora.org> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/ath/wil6210/txrx_edma.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1137,7 +1137,7 @@ int wil_tx_sring_handler(struct wil6210_priv *wil,
		/* Total number of completed descriptors in all descriptor rings */
		int desc_cnt = 0;
		int cid;
		struct wil_net_stats *stats = NULL;
		struct wil_net_stats *stats;
		struct wil_tx_enhanced_desc *_d;
		unsigned int ring_id;
		unsigned int num_descs;
		@@ -1187,8 +1187,7 @@ int wil_tx_sring_handler(struct wil6210_priv *wil,
		ndev = vif_to_ndev(vif);

		cid = wil->ring2cid_tid[ring_id][0];
		if (cid < max_assoc_sta)
		stats = &wil->sta[cid].stats;
		stats = (cid < max_assoc_sta ? &wil->sta[cid].stats : NULL);

		wil_dbg_txrx(wil,
		"tx_status: completed desc_ring (%d), num_descs (%d)\n",

Admin message