Commit a362357b authored by Jens Axboe's avatar Jens Axboe
Browse files

[BLOCK] Unify the seperate read/write io stat fields into arrays 



Instead of having ->read_sectors and ->write_sectors, combine the two
into ->sectors[2] and similar for the other fields. This saves a branch
several places in the io path, since we don't have to care for what the
actual io direction is. On my x86-64 box, that's 200 bytes less text in
just the core (not counting the various drivers).

Signed-off-by: default avatarJens Axboe <axboe@suse.de>
parent d72d904a

drivers/block/genhd.c

+14 −15
Original line number Original line Diff line number Diff line
@@ -391,13 +391,12 @@ static ssize_t disk_stats_read(struct gendisk * disk, char *page) 
		"%8u %8u %8llu %8u "

		"%8u %8u %8llu %8u "

		"%8u %8u %8u"

		"%8u %8u %8u"

		"\n",

		"\n",

		disk_stat_read(disk, reads), disk_stat_read(disk, read_merges),

		disk_stat_read(disk, ios[0]), disk_stat_read(disk, merges[0]),

		(unsigned long long)disk_stat_read(disk, read_sectors),

		(unsigned long long)disk_stat_read(disk, sectors[0]),

		jiffies_to_msecs(disk_stat_read(disk, read_ticks)),

		jiffies_to_msecs(disk_stat_read(disk, ticks[0])),

		disk_stat_read(disk, writes), 

		disk_stat_read(disk, ios[1]), disk_stat_read(disk, merges[1]),

		disk_stat_read(disk, write_merges),

		(unsigned long long)disk_stat_read(disk, sectors[1]),

		(unsigned long long)disk_stat_read(disk, write_sectors),

		jiffies_to_msecs(disk_stat_read(disk, ticks[1])),

		jiffies_to_msecs(disk_stat_read(disk, write_ticks)),

		disk->in_flight,

		disk->in_flight,

		jiffies_to_msecs(disk_stat_read(disk, io_ticks)),

		jiffies_to_msecs(disk_stat_read(disk, io_ticks)),

		jiffies_to_msecs(disk_stat_read(disk, time_in_queue)));

		jiffies_to_msecs(disk_stat_read(disk, time_in_queue)));
@@ -583,12 +582,12 @@ static int diskstats_show(struct seq_file *s, void *v) 
	preempt_enable();

	preempt_enable();

	seq_printf(s, "%4d %4d %s %u %u %llu %u %u %u %llu %u %u %u %u\n",

	seq_printf(s, "%4d %4d %s %u %u %llu %u %u %u %llu %u %u %u %u\n",

		gp->major, n + gp->first_minor, disk_name(gp, n, buf),

		gp->major, n + gp->first_minor, disk_name(gp, n, buf),

		disk_stat_read(gp, reads), disk_stat_read(gp, read_merges),

		disk_stat_read(gp, ios[0]), disk_stat_read(gp, merges[0]),

		(unsigned long long)disk_stat_read(gp, read_sectors),

		(unsigned long long)disk_stat_read(gp, sectors[0]),

		jiffies_to_msecs(disk_stat_read(gp, read_ticks)),

		jiffies_to_msecs(disk_stat_read(gp, ticks[0])),

		disk_stat_read(gp, writes), disk_stat_read(gp, write_merges),

		disk_stat_read(gp, ios[1]), disk_stat_read(gp, merges[1]),

		(unsigned long long)disk_stat_read(gp, write_sectors),

		(unsigned long long)disk_stat_read(gp, sectors[1]),

		jiffies_to_msecs(disk_stat_read(gp, write_ticks)),

		jiffies_to_msecs(disk_stat_read(gp, ticks[1])),

		gp->in_flight,

		gp->in_flight,

		jiffies_to_msecs(disk_stat_read(gp, io_ticks)),

		jiffies_to_msecs(disk_stat_read(gp, io_ticks)),

		jiffies_to_msecs(disk_stat_read(gp, time_in_queue)));

		jiffies_to_msecs(disk_stat_read(gp, time_in_queue)));
@@ -601,8 +600,8 @@ static int diskstats_show(struct seq_file *s, void *v) 
			seq_printf(s, "%4d %4d %s %u %u %u %u\n",

			seq_printf(s, "%4d %4d %s %u %u %u %u\n",

				gp->major, n + gp->first_minor + 1,

				gp->major, n + gp->first_minor + 1,

				disk_name(gp, n + 1, buf),

				disk_name(gp, n + 1, buf),

				hd->reads, hd->read_sectors,

				hd->ios[0], hd->sectors[0],

				hd->writes, hd->write_sectors);

				hd->ios[1], hd->sectors[1]);

	}

	}

 

 

	return 0;

	return 0;

drivers/block/ll_rw_blk.c

+12 −28
Original line number Original line Diff line number Diff line
@@ -2388,10 +2388,7 @@ static void drive_stat_acct(struct request *rq, int nr_sectors, int new_io) 
		return;

		return;





	if (!new_io) {

	if (!new_io) {

		if (rw == READ)

		__disk_stat_inc(rq->rq_disk, merges[rw]);

			__disk_stat_inc(rq->rq_disk, read_merges);

		else

			__disk_stat_inc(rq->rq_disk, write_merges);

	} else {

	} else {

		disk_round_stats(rq->rq_disk);

		disk_round_stats(rq->rq_disk);

		rq->rq_disk->in_flight++;

		rq->rq_disk->in_flight++;
@@ -2787,17 +2784,11 @@ static inline void blk_partition_remap(struct bio *bio) 




	if (bdev != bdev->bd_contains) {

	if (bdev != bdev->bd_contains) {

		struct hd_struct *p = bdev->bd_part;

		struct hd_struct *p = bdev->bd_part;

		const int rw = bio_data_dir(bio);



		p->sectors[rw] += bio_sectors(bio);

		p->ios[rw]++;





		switch (bio_data_dir(bio)) {

		case READ:

			p->read_sectors += bio_sectors(bio);

			p->reads++;

			break;

		case WRITE:

			p->write_sectors += bio_sectors(bio);

			p->writes++;

			break;

		}

		bio->bi_sector += p->start_sect;

		bio->bi_sector += p->start_sect;

		bio->bi_bdev = bdev->bd_contains;

		bio->bi_bdev = bdev->bd_contains;

	}

	}
@@ -3045,10 +3036,9 @@ static int __end_that_request_first(struct request *req, int uptodate, 
	}

	}





	if (blk_fs_request(req) && req->rq_disk) {

	if (blk_fs_request(req) && req->rq_disk) {

		if (rq_data_dir(req) == READ)

		const int rw = rq_data_dir(req);

			__disk_stat_add(req->rq_disk, read_sectors, nr_bytes >> 9);



		else

		__disk_stat_add(req->rq_disk, sectors[rw], nr_bytes >> 9);

			__disk_stat_add(req->rq_disk, write_sectors, nr_bytes >> 9);

	}

	}





	total_bytes = bio_nbytes = 0;

	total_bytes = bio_nbytes = 0;
@@ -3179,16 +3169,10 @@ void end_that_request_last(struct request *req) 




	if (disk && blk_fs_request(req)) {

	if (disk && blk_fs_request(req)) {

		unsigned long duration = jiffies - req->start_time;

		unsigned long duration = jiffies - req->start_time;

		switch (rq_data_dir(req)) {

		const int rw = rq_data_dir(req);

		    case WRITE:



			__disk_stat_inc(disk, writes);

		__disk_stat_inc(disk, ios[rw]);

			__disk_stat_add(disk, write_ticks, duration);

		__disk_stat_add(disk, ticks[rw], duration);

			break;

		    case READ:

			__disk_stat_inc(disk, reads);

			__disk_stat_add(disk, read_ticks, duration);

			break;

		}

		disk_round_stats(disk);

		disk_round_stats(disk);

		disk->in_flight--;

		disk->in_flight--;

	}

	}

drivers/md/linear.c

+3 −7
Original line number Original line Diff line number Diff line
@@ -271,6 +271,7 @@ static int linear_stop (mddev_t *mddev) 




static int linear_make_request (request_queue_t *q, struct bio *bio)

static int linear_make_request (request_queue_t *q, struct bio *bio)

{

{

	const int rw = bio_data_dir(bio);

	mddev_t *mddev = q->queuedata;

	mddev_t *mddev = q->queuedata;

	dev_info_t *tmp_dev;

	dev_info_t *tmp_dev;

	sector_t block;

	sector_t block;
@@ -280,13 +281,8 @@ static int linear_make_request (request_queue_t *q, struct bio *bio) 
		return 0;

		return 0;

	}

	}





	if (bio_data_dir(bio)==WRITE) {

	disk_stat_inc(mddev->gendisk, ios[rw]);

		disk_stat_inc(mddev->gendisk, writes);

	disk_stat_add(mddev->gendisk, sectors[rw], bio_sectors(bio));

		disk_stat_add(mddev->gendisk, write_sectors, bio_sectors(bio));

	} else {

		disk_stat_inc(mddev->gendisk, reads);

		disk_stat_add(mddev->gendisk, read_sectors, bio_sectors(bio));

	}





	tmp_dev = which_dev(mddev, bio->bi_sector);

	tmp_dev = which_dev(mddev, bio->bi_sector);

	block = bio->bi_sector >> 1;

	block = bio->bi_sector >> 1;

drivers/md/md.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -3466,8 +3466,8 @@ static int is_mddev_idle(mddev_t *mddev) 
	idle = 1;

	idle = 1;

	ITERATE_RDEV(mddev,rdev,tmp) {

	ITERATE_RDEV(mddev,rdev,tmp) {

		struct gendisk *disk = rdev->bdev->bd_contains->bd_disk;

		struct gendisk *disk = rdev->bdev->bd_contains->bd_disk;

		curr_events = disk_stat_read(disk, read_sectors) + 

		curr_events = disk_stat_read(disk, sectors[0]) + 

				disk_stat_read(disk, write_sectors) - 

				disk_stat_read(disk, sectors[1]) - 

				atomic_read(&disk->sync_io);

				atomic_read(&disk->sync_io);

		/* Allow some slack between valud of curr_events and last_events,

		/* Allow some slack between valud of curr_events and last_events,

		 * as there are some uninteresting races.

		 * as there are some uninteresting races.

drivers/md/multipath.c

+3 −7
Original line number Original line Diff line number Diff line
@@ -168,6 +168,7 @@ static int multipath_make_request (request_queue_t *q, struct bio * bio) 
	multipath_conf_t *conf = mddev_to_conf(mddev);

	multipath_conf_t *conf = mddev_to_conf(mddev);

	struct multipath_bh * mp_bh;

	struct multipath_bh * mp_bh;

	struct multipath_info *multipath;

	struct multipath_info *multipath;

	const int rw = bio_data_dir(bio);





	if (unlikely(bio_barrier(bio))) {

	if (unlikely(bio_barrier(bio))) {

		bio_endio(bio, bio->bi_size, -EOPNOTSUPP);

		bio_endio(bio, bio->bi_size, -EOPNOTSUPP);
@@ -179,13 +180,8 @@ static int multipath_make_request (request_queue_t *q, struct bio * bio) 
	mp_bh->master_bio = bio;

	mp_bh->master_bio = bio;

	mp_bh->mddev = mddev;

	mp_bh->mddev = mddev;





	if (bio_data_dir(bio)==WRITE) {

	disk_stat_inc(mddev->gendisk, ios[rw]);

		disk_stat_inc(mddev->gendisk, writes);

	disk_stat_add(mddev->gendisk, sectors[rw], bio_sectors(bio));

		disk_stat_add(mddev->gendisk, write_sectors, bio_sectors(bio));

	} else {

		disk_stat_inc(mddev->gendisk, reads);

		disk_stat_add(mddev->gendisk, read_sectors, bio_sectors(bio));

	}





	mp_bh->path = multipath_map(conf);

	mp_bh->path = multipath_map(conf);

	if (mp_bh->path < 0) {

	if (mp_bh->path < 0) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE