Unverified Commit a33c0d16 authored Aug 20, 2019 by Kuninori Morimoto Committed by Mark Brown Aug 22, 2019

ASoC: soc-core: add NOTE to snd_soc_rtdcom_lookup()



We can find specified name component via snd_soc_rtdcom_lookup().
But, it is not enough under multi CPU/Codec/Platform, because many
components which have same driver name might be connected to same rtd.

Not using this function as much as possible is best solution,
but some drivers are already deeply depended to it.

We can expand this function, for example having "num" which specifies
found order at parameter, etc (In such case, it need to have fixed
probing order).
Or, use different driver name in such component, etc.

We will have such issue if multi CPU/Codec/Platform were supported.
To indicate it, this patch adds NOTE to this function.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/874l2c1ldi.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4168ddab

sound/soc/soc-core.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -315,6 +315,14 @@ struct snd_soc_component snd_soc_rtdcom_lookup(struct snd_soc_pcm_runtime rtd,
		if (!driver_name)
		return NULL;

		/*
		* NOTE
		*
		* snd_soc_rtdcom_lookup() will find component from rtd by using
		* specified driver name.
		* But, if many components which have same driver name are connected
		* to 1 rtd, this function will return 1st found component.
		*/
		for_each_rtdcom(rtd, rtdcom) {
		const char *component_name = rtdcom->component->driver->name;

Admin message