ring-buffer: Remove obsolete rb_event_is_commit() (a32ded33) · Commits · 戴 / test

Commit ("ring-buffer: Have nested events still record running time stamp") removed the only uses of rb_event_is_commit() in rb_update_event() and rb_update_write_stamp(). Hence, since then, make CC=clang W=1 warns: kernel/trace/ring_buffer.c:2763:1: warning: unused function 'rb_event_is_commit' [-Wunused-function] Remove this obsolete function. Link: https://lkml.kernel.org/r/20201117053703.11275-1-lukas.bulwahn@gmail.com Reviewed-by:

Nathan Chancellor <natechancellor@gmail.com> Signed-off-by:

Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by:

Steven Rostedt (VMware) <rostedt@goodmis.org>

kernel/trace/ring_buffer.c

+0 −17

Original line number	Diff line number	Diff line
		@@ -2629,9 +2629,6 @@ rb_add_time_stamp(struct ring_buffer_event *event, u64 delta, bool abs)
		return skip_time_extend(event);
		}

		static inline bool rb_event_is_commit(struct ring_buffer_per_cpu *cpu_buffer,
		struct ring_buffer_event *event);

		#ifndef CONFIG_HAVE_UNSTABLE_SCHED_CLOCK
		static inline bool sched_clock_stable(void)
		{
		@@ -2759,20 +2756,6 @@ static unsigned rb_calculate_event_length(unsigned length)
		return length;
		}

		static __always_inline bool
		rb_event_is_commit(struct ring_buffer_per_cpu *cpu_buffer,
		struct ring_buffer_event *event)
		{
		unsigned long addr = (unsigned long)event;
		unsigned long index;

		index = rb_event_index(event);
		addr &= PAGE_MASK;

		return cpu_buffer->commit_page->page == (void *)addr &&
		rb_commit_index(cpu_buffer) == index;
		}

		static u64 rb_time_delta(struct ring_buffer_event *event)
		{
		switch (event->type_len) {

Admin message