Unverified Commit a325c7bc authored Aug 26, 2019 by Dan Carpenter Committed by Mark Brown Aug 27, 2019

ASoC: SOF: imx8: Fix an is IS_ERR() vs NULL check



The device_link_add() function only returns NULL on error, it doesn't
return error pointers.

Fixes: 202acc56 ("ASoC: SOF: imx: Add i.MX8 HW support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://lore.kernel.org/r/20190826131855.GA6840@mwanda


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 9ec05d47

sound/soc/sof/imx/imx8.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -227,8 +227,8 @@ static int imx8_probe(struct snd_sof_dev *sdev)
		DL_FLAG_STATELESS \|
		DL_FLAG_PM_RUNTIME \|
		DL_FLAG_RPM_ACTIVE);
		if (IS_ERR(priv->link[i])) {
		ret = PTR_ERR(priv->link[i]);
		if (!priv->link[i]) {
		ret = -ENOMEM;
		dev_pm_domain_detach(priv->pd_dev[i], false);
		goto exit_unroll_pm;
		}

Admin message