Commit a3132499 authored Nov 04, 2013 by Colin Leitner Committed by Greg Kroah-Hartman Dec 02, 2013

USB: pl2303: fixed handling of CS5 setting



This patch fixes the CS5 setting on the PL2303 USB-to-serial devices. CS5 has a
value of 0 and the CSIZE setting has been skipped altogether by the enclosing
if. Tested on 3.11.6 and the scope shows the correct output after the fix has
been applied.

Tagged to be added to stable, because it fixes a user visible driver bug and is
simple enough to backport easily.

Signed-off-by: Colin Leitner <colin.leitner@gmail.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8704211f

drivers/usb/serial/pl2303.c

+14 −16

Original line number	Diff line number	Diff line
		@@ -361,7 +361,6 @@ static void pl2303_set_termios(struct tty_struct *tty,
		0, 0, buf, 7, 100);
		dev_dbg(&port->dev, "0xa1:0x21:0:0 %d - %7ph\n", i, buf);

		if (C_CSIZE(tty)) {
		switch (C_CSIZE(tty)) {
		case CS5:
		buf[6] = 5;
		@@ -377,7 +376,6 @@ static void pl2303_set_termios(struct tty_struct *tty,
		buf[6] = 8;
		}
		dev_dbg(&port->dev, "data bits = %d\n", buf[6]);
		}

		/* For reference buf[0]:buf[3] baud rate value */
		pl2303_encode_baudrate(tty, port, &buf[0]);

Admin message