Commit a307593a authored by Doug Berger's avatar Doug Berger Committed by David S. Miller
Browse files

net: phy: simplify phy_link_change arguments 



This function was introduced to allow for different handling of
link up and link down events particularly with regard to the
netif_carrier. The third argument do_carrier allowed the flag to
be left unchanged.

Since then the phylink has introduced an implementation that
completely ignores the third parameter since it never wants to
change the flag and the phylib always sets the third parameter
to true so the flag is always changed.

Therefore the third argument (i.e. do_carrier) is no longer
necessary and can be removed. This also means that the phylib
phy_link_down() function no longer needs its second argument.

Signed-off-by: default avatarDoug Berger <opendmb@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dbfe7d74

drivers/net/phy/phy.c

+6 −6
Original line number Diff line number Diff line
@@ -58,13 +58,13 @@ static const char *phy_state_to_str(enum phy_state st) 


static void phy_link_up(struct phy_device *phydev)

{

	phydev->phy_link_change(phydev, true, true);

	phydev->phy_link_change(phydev, true);

	phy_led_trigger_change_speed(phydev);

}



static void phy_link_down(struct phy_device *phydev, bool do_carrier)

static void phy_link_down(struct phy_device *phydev)

{

	phydev->phy_link_change(phydev, false, do_carrier);

	phydev->phy_link_change(phydev, false);

	phy_led_trigger_change_speed(phydev);

}
@@ -524,7 +524,7 @@ int phy_start_cable_test(struct phy_device *phydev, 
		goto out;



	/* Mark the carrier down until the test is complete */

	phy_link_down(phydev, true);

	phy_link_down(phydev);



	netif_testing_on(dev);

	err = phydev->drv->cable_test_start(phydev);
@@ -595,7 +595,7 @@ static int phy_check_link_status(struct phy_device *phydev) 
		phy_link_up(phydev);

	} else if (!phydev->link && phydev->state != PHY_NOLINK) {

		phydev->state = PHY_NOLINK;

		phy_link_down(phydev, true);

		phy_link_down(phydev);

	}



	return 0;
@@ -999,7 +999,7 @@ void phy_state_machine(struct work_struct *work) 
	case PHY_HALTED:

		if (phydev->link) {

			phydev->link = 0;

			phy_link_down(phydev, true);

			phy_link_down(phydev);

		}

		do_suspend = true;

		break;

drivers/net/phy/phy_device.c

+5 −7
Original line number Diff line number Diff line
@@ -916,16 +916,14 @@ struct phy_device *phy_find_first(struct mii_bus *bus) 
}

EXPORT_SYMBOL(phy_find_first);



static void phy_link_change(struct phy_device *phydev, bool up, bool do_carrier)

static void phy_link_change(struct phy_device *phydev, bool up)

{

	struct net_device *netdev = phydev->attached_dev;



	if (do_carrier) {

	if (up)

		netif_carrier_on(netdev);

	else

		netif_carrier_off(netdev);

	}

	phydev->adjust_link(netdev);

	if (phydev->mii_ts && phydev->mii_ts->link_state)

		phydev->mii_ts->link_state(phydev->mii_ts, phydev);

drivers/net/phy/phylink.c

+1 −2
Original line number Diff line number Diff line
@@ -803,8 +803,7 @@ void phylink_destroy(struct phylink *pl) 
}

EXPORT_SYMBOL_GPL(phylink_destroy);



static void phylink_phy_change(struct phy_device *phydev, bool up,

			       bool do_carrier)

static void phylink_phy_change(struct phy_device *phydev, bool up)

{

	struct phylink *pl = phydev->phylink;

	bool tx_pause, rx_pause;

include/linux/phy.h

+1 −1
Original line number Diff line number Diff line
@@ -543,7 +543,7 @@ struct phy_device { 
	u8 mdix;

	u8 mdix_ctrl;



	void (*phy_link_change)(struct phy_device *, bool up, bool do_carrier);

	void (*phy_link_change)(struct phy_device *phydev, bool up);

	void (*adjust_link)(struct net_device *dev);



#if IS_ENABLED(CONFIG_MACSEC)

CRA Git | Maintained and supported by SUSTech CRA and CCSE