Commit a2fce914 authored Apr 17, 2013 by Naoya Horiguchi Committed by Linus Torvalds Apr 17, 2013

hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)



Currently we fail to include any data on hugepages into coredump,
because VM_DONTDUMP is set on hugetlbfs's vma.  This behavior was
recently introduced by commit 314e51b9 ("mm: kill vma flag
VM_RESERVED and mm->reserved_vm counter").

This looks to me a serious regression, so let's fix it.

Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Rik van Riel <riel@redhat.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: <stable@vger.kernel.org>	[3.7+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e942e2c3

fs/hugetlbfs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file file, struct vm_area_struct vma)
		* way when do_mmap_pgoff unwinds (may be important on powerpc
		* and ia64).
		*/
		vma->vm_flags \|= VM_HUGETLB \| VM_DONTEXPAND \| VM_DONTDUMP;
		vma->vm_flags \|= VM_HUGETLB \| VM_DONTEXPAND;
		vma->vm_ops = &hugetlb_vm_ops;

		if (vma->vm_pgoff & (~huge_page_mask(h) >> PAGE_SHIFT))

Admin message