Commit a2f04243 authored Aug 15, 2017 by Peter Griffin Committed by Xinliang Liu Nov 01, 2017

drm/hisilicon: Ensure LDI regs are properly configured.



This patch fixes the following soft lockup:
  BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]

On weston idle-timeout the IP is powered down and reset
asserted. On weston resume we get a massive vblank
IRQ storm due to the LDI registers having lost some state.

This state loss is caused by ade_crtc_atomic_begin() not
calling ade_ldi_set_mode(). With this patch applied
resuming from Weston idle-timeout works well.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Cc: stable@vger.kernel.org
Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>

parent 62884cd3

drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -534,9 +534,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc,
		{
		struct ade_crtc *acrtc = to_ade_crtc(crtc);
		struct ade_hw_ctx *ctx = acrtc->ctx;
		struct drm_display_mode *mode = &crtc->state->mode;
		struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;

		if (!ctx->power_on)
		(void)ade_power_up(ctx);
		ade_ldi_set_mode(acrtc, mode, adj_mode);
		}

		static void ade_crtc_atomic_flush(struct drm_crtc *crtc,

Admin message