Commit a2e91381 authored Oct 06, 2011 by Lars Ellenberg Committed by Philipp Reisner May 09, 2012

drbd: fix spurious meta data IO "error"

When detaching, even cleanly detaching due to administrator request,
we always go through D_FAILED before we become D_DISKLESS.

Don't let that state change race with an in-flight meta data IO,
or that one might think it actually experienced an IO error.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

parent aaae506d

drivers/block/drbd/drbd_nl.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1351,7 +1351,9 @@ static int drbd_nl_detach(struct drbd_conf mdev, struct drbd_nl_cfg_req nlp,
		}

		drbd_suspend_io(mdev); /* so no-one is stuck in drbd_al_begin_io */
		drbd_md_get_buffer(mdev); /* make sure there is no in-flight meta-data IO */
		retcode = drbd_request_state(mdev, NS(disk, D_FAILED));
		drbd_md_put_buffer(mdev);
		/* D_FAILED will transition to DISKLESS. */
		ret = wait_event_interruptible(mdev->misc_wait,
		mdev->state.disk != D_FAILED);