net: phy: fixed: return an error for Clause 45 over 22 reads (a2dbba76) · Commits · 戴 / test

The fixed PHY driver does not properly emulate Clause 45 over Clause 22 MDIO reads, and as such, will return bogus values when we access such registers. Return an error when accessing these registers in order to prevent advertising bogus capabilities such as EEE support and such. Signed-off-by:

Florian Fainelli <f.fainelli@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/phy/fixed.c

+11 −0

Original line number	Original line	Diff line number	Diff line
	@@ -124,6 +124,17 @@ static int fixed_mdio_read(struct mii_bus *bus, int phy_addr, int reg_num)
	if (reg_num >= MII_REGS_NUM)		if (reg_num >= MII_REGS_NUM)
	return -1;		return -1;

			/* We do not support emulating Clause 45 over Clause 22 register reads
			* return an error instead of bogus data.
			*/
			switch (reg_num) {
			case MII_MMD_CTRL:
			case MII_MMD_DATA:
			return -1;
			default:
			break;
			}

	list_for_each_entry(fp, &fmb->phys, node) {		list_for_each_entry(fp, &fmb->phys, node) {
	if (fp->addr == phy_addr) {		if (fp->addr == phy_addr) {
	/* Issue callback if user registered it. */		/* Issue callback if user registered it. */

Admin message