Commit a2d074e4 authored Oct 01, 2019 by Brian Vazquez Committed by Daniel Borkmann Oct 02, 2019

selftests/bpf: test_progs: Don't leak server_fd in test_sockopt_inherit



server_fd needs to be closed if pthread can't be created.

Fixes: e3e02e1d ("selftests/bpf: test_progs: convert test_sockopt_inherit")
Signed-off-by: Brian Vazquez <brianvv@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20191001173728.149786-3-brianvv@google.com

parent 86c1aea8

tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -195,7 +195,7 @@ static void run_test(int cgroup_fd)

		if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread,
		(void *)&server_fd)))
		goto close_bpf_object;
		goto close_server_fd;

		pthread_mutex_lock(&server_started_mtx);
		pthread_cond_wait(&server_started, &server_started_mtx);

Admin message